Phoenix - FloatCanvas

[Werner]

Hi,

What about a smallish refactor of floatcanvas for Phoenix?

- move all "Draw" objects to a new module called e.g. FCObjects.py
- move specialobjects.PieChart to the above and remove that sub package
- move all the tests in BBoxTest.py to test_lib_floatcanvas_bbox.py in
the unittest folder and remove it from fc.Utilities

I have done that on my Py33 test setup and all defined unittests work,
the demo works and the samples.fc.PieChart.py works too (module not
callable except mentioned in previous msg is gone).

Werner

[Chris Barker]

Werner,

Post by Werner
What about a smallish refactor of floatcanvas for Phoenix?
- move all "Draw" objects to a new module called e.g. FCObjects.py

That's been an idea of mine for a long time -- so yes!

Post by Werner
- move specialobjects.PieChart to the above and remove that sub package

sure -- I can't really recall why I kept that separate -- I think maybe
because I wanted a clear demo of how to write such a special, compound
object. It felt like a different concept than the rest of the DrawObjets
that all map more or less to a single DC draw call.

- move all the tests in BBoxTest.py to test_lib_floatcanvas_bbox.py in the

Post by Werner
unittest folder and remove it from fc.Utilities

yup -- that is a legacy of my early experiments with unit testing, and not
realy knowing how best to structure things.


I have done that on my Py33 test setup and all defined unittests work, the

Post by Werner
demo works and the samples.fc.PieChart.py works too (module not callable
except mentioned in previous msg is gone).

sounds good. I winder if the issue there was a relative imports thing....

-Chris
--
Christopher Barker, Ph.D.
Oceanographer

Emergency Response Division
NOAA/NOS/OR&R [phone] voice
7600 Sand Point Way NE [phone] fax
Seattle, WA 98115 [phone] main reception

***@noaa.gov

[Werner]

Good morning,

Post by Chris Barker
Werner,

No problem.

Did some more testing on Py2.7 with the changes, now things work for me
on Py2.7 and Py3.3, that is the demo and unittests and I also checked a
few samples.

Committed it and it is added to the previous FloatCanvas related PR 78.

Werner

Post by Chris Barker
What about a smallish refactor of floatcanvas for Phoenix?
- move all "Draw" objects to a new module called e.g. FCObjects.py
That's been an idea of mine for a long time -- so yes!
- move specialobjects.PieChart to the above and remove that sub package
sure -- I can't really recall why I kept that separate -- I think
maybe because I wanted a clear demo of how to write such a special,
compound object. It felt like a different concept than the rest of the
DrawObjets that all map more or less to a single DC draw call.
- move all the tests in BBoxTest.py to
test_lib_floatcanvas_bbox.py in the unittest folder and remove it
from fc.Utilities
yup -- that is a legacy of my early experiments with unit testing, and
not realy knowing how best to structure things.
I have done that on my Py33 test setup and all defined unittests
work, the demo works and the samples.fc.PieChart.py
<http://samples.fc.PieChart.py> works too (module not callable
except mentioned in previous msg is gone).
sounds good. I winder if the issue there was a relative imports thing....
-Chris
--
Christopher Barker, Ph.D.
Oceanographer
Emergency Response Division
NOAA/NOS/OR&R [phone] voice
7600 Sand Point Way NE [phone] fax
Seattle, WA 98115 [phone] main reception
--
You received this message because you are subscribed to the Google
Groups "wxPython-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
For more options, visit https://groups.google.com/d/optout.